Closed
Bug 760021
Opened 12 years ago
Closed 12 years ago
rsync-motd is broken for mozilla-releases and mozilla-current
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nthomas, Assigned: nthomas)
Details
Attachments
(1 file, 1 obsolete file)
5.00 KB,
patch
|
rail
:
review+
nthomas
:
checked-in+
|
Details | Diff | Splinter Review |
I trimmed the modules today and it's still reporting mozilla-releases: 132GB mozilla-current: 31GB
Assignee | ||
Comment 1•12 years ago
|
||
Lots of historical cruft getting the chop here, in favour of doing rsync -n and parsing the lines like this: total size is 194350446326 speedup is 64600.04 (DRY RUN)
Attachment #628634 -
Flags: review?(rail)
Comment 2•12 years ago
|
||
Comment on attachment 628634 [details] [diff] [review] [svn] rework motd Review of attachment 628634 [details] [diff] [review]: ----------------------------------------------------------------- ::: manifests/upload_cron.pp @@ +55,2 @@ > mode => 755, > source => "puppet:///modules/productdelivery/bin/get-prereleases-size"; I'm not sure if I understand this part. It looks like you're removing get-prereleases-size in your patch (or trimming the file to 0, depending on how you apply the patch), but here you are trying to use the content of removed file...
Assignee | ||
Comment 3•12 years ago
|
||
Good catch, this fixes that up.
Attachment #628634 -
Attachment is obsolete: true
Attachment #628634 -
Flags: review?(rail)
Attachment #628965 -
Flags: review?(rail)
Comment 4•12 years ago
|
||
hmmm, I'm still getting errors trying to apply the patch: $ svn co svn+ssh://svn.mozilla.org/sysadmins/puppet/trunk/modules/productdelivery $ wget -O - https://bug760021.bugzilla.mozilla.org/attachment.cgi?id=628965 | patch -p0 patching file files/cron.d/motd-gen patching file files/bin/get-prereleases-size patching file files/bin/motd-gen.sh can't find file to patch at input line 84 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: files/bin/get-rsync-module-size |=================================================================== |--- files/bin/get-rsync-module-size (revision 39606) |+++ files/bin/get-rsync-module-size (working copy) -------------------------- File to patch: Skip this patch? [y] Any ideas why it happens?
Comment 5•12 years ago
|
||
svn info: URL: svn+ssh://svn.mozilla.org/sysadmins/puppet/trunk/modules/productdelivery Repository Root: svn+ssh://svn.mozilla.org/sysadmins Repository UUID: 65d70b31-241a-0410-a745-f8fa14660ae9 Revision: 39712 Node Kind: directory Schedule: normal Last Changed Author: catlee@mozilla.com Last Changed Rev: 39630 Last Changed Date: 2012-05-31 07:45:44 -0400 (Thu, 31 May 2012)
Assignee | ||
Comment 6•12 years ago
|
||
Might be a noob when it comes to add/delete/moving files in SVN. I used svn move to create get-rsync-module-size. You can do cp files/bin/{get-prereleases-size,get-rsync-module-size} to apply the patch.
Updated•12 years ago
|
Attachment #628965 -
Flags: review?(rail) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 628965 [details] [diff] [review] [svn] rework motd, v2 Committed revision 39924.
Attachment #628965 -
Flags: checked-in+
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•